Ryan Johnson

Results 31 comments of Ryan Johnson

Ah! The URL's are messed-up! They have the `/docs` embedded twice, and that triggers the redirect, which in turn triggers the attempt at a URL reversal of `wiki.document`, which should...

> Ah, crap. Maybe I broke it here? [9a89d2d?diff=split](https://github.com/mdn/kuma/commit/9a89d2dd3377c52ca407f3c56e89cdc2defc649a?diff=split) @callahad Hm, I don't think so. I suspected that at first, but your code changes seem to work great. I'm baffled...

@callahad Hm, I'm currently suspecting that there's a problem with the `EmedLiveSample.ejs` macro or some other macro involved in the creation of code sample URL's.

@callahad and I have concluded that this is NOT a new error caused by the upgrade to Django 2.2. My personal suspicion is that there are documents with bad calls...

@callahad @peterbe That's it! Here's the offending document: https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext It makes the following macro call to embed a live code sample: ```javascript {{EmbedLiveSample("canvas-size-and-webgl-source", 660,180 ,"" , "/en-US/docs/Web/API/WebGL_API/By_example/Canvas_size_and_WebGL")}} ``` but that...

I fixed the English document (https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext). It's six translations were all fine, so it was limited to the English document. It seems, from the Sentry events I've seen, all of...

Closing since I think this is due to a bad macro call within a single document, which I've fixed. This consumed my entire working (non-meeting) time today, as well as...

This occurs under the following conditions: - Focus uses a SUMO-provided "inproduct" link to a SUMO article or page, for example something like https://support.mozilla.org/1/mobile/{version}/{platform}/{locale}/whats-new-firefox-focus-android, where Focus fills in the `{version}`,...

Just FYI: https://github.com/mozilla/kitsune/pull/5246

https://github.com/mozilla/kitsune/pull/5246 has been released on SUMO (support.mozilla.org), so this should be fixed now. For example, all of the following "inproduct" links now gracefully redirect to the default locale: https://support.mozilla.org/1/mobile/105/Android/ia/whats-new-firefox-focus-android https://support.mozilla.org/1/mobile/105/Android/co/whats-new-firefox-focus-android...