Egor Blinov
Egor Blinov
Agree, it shouldn't fix the issue, as there is still https://github.com/web-infra-dev/rspack/blob/2bd905d47e731772365637188c929f5371e60267/packages/rspack/src/node/NodeWatchFileSystem.ts#L108 running every time. > actually it works for add module but not idea for remove module since reuse the...
But in order for watcher to start watching it, the `Watchpack::watch` needs to be called.
I'm in doubt about where to add the early bailout: - doing it in `NodeWatchFileSystem.ts` or `Watching.ts` is less of a hassle, but there the type of `files, dirs and...
Can you point where to look?
@jerrykingxyz @hardfist Since the added/removed compilation dependencies are now exposed, I can contribute the fix for the watcher, if you haven't started working on it yet.
Found a duplicate PR: https://github.com/vuejs/vue-loader/pull/2045 with slightly different approach to HMR, but a lot more tests
@yyx990803 @Jinjiang calling you directly, as the repo seems almost abandoned. Could you please take a look at this or #2045 and merge one of them?
UPD: the problem appears only when using opencode-desktop, when opening localhost:4096 (by the opencode cli) it works fine.