escapedcat

Results 637 comments of escapedcat

@kamathgopal which commitlint version are you using? According to this issue it's fixed: #3208 I just tried this with current master ```sh echo "#123 - test commit" | ./@commitlint/cli/cli.js ⧗...

> BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with [MAJOR](http://semver.org/#summary) in Semantic Versioning). A...

I think my main point was that `BREAKING CHANGE: is a footer thing` should not work according to the spec

> @escapedcat, so the test for `BREAKING CHANGE:` as the first line should return `false`, right? I think so, yes. It's only valid to add `BREAKING CHANGE:` to the commit-footer,...

Not sure when I have time to look into it. You can try to output the result like this maybe: ```js console.log(JSON.stringify(YOUR_JEST_RESULT)) ```

I assume the issue here is that it doesn't find a subject because the type already failes? commitlint assumes `BREAKING CHANGE:` is the `type` which isn't a valid `type`? Not...

Thanks people! We good here now?

Alright, let me switch this to draft for now

Sorry, can't really answer this question

Does this help in any way?: https://github.com/typicode/husky/issues/1014