school2021 icon indicating copy to clipboard operation
school2021 copied to clipboard

Added my sign off to the logbook

Open GabrielF98 opened this issue 4 years ago • 6 comments

Thanks so much to all of you this is the best school I have attended.

GabrielF98 avatar Jun 17 '21 20:06 GabrielF98

Hi Max,

Sorry about this, what’s the best way to remove these files I seem to be having trouble

Thanks,

Gabriel

On 17 Jun 2021, at 21:23, Maximilian Nöthe @.***> wrote:

@maxnoe requested changes on this pull request.

High, thanks, but you added many unnecessary files here. See the files tab here on github.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/escape2020/school2021/pull/98#pullrequestreview-686764927, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARK5J3JEMWQ2R2EV3OGBGXTTTJKVJANCNFSM464LM67Q.

GabrielF98 avatar Jun 17 '21 20:06 GabrielF98

Hi @GabrielF98 -- if you want to keep those files on your machine, but removing them from the index, you would use for example:

git rm --cached <unnecessary filename>

JulienPeloton avatar Jun 17 '21 20:06 JulienPeloton

I think I have done this now?

On 17 Jun 2021, at 21:47, Julien @.***> wrote:

Hi @GabrielF98 https://github.com/GabrielF98 -- if you want to keep those files on your machine, but removing them from the index, you would use for example:

git rm --cached — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/escape2020/school2021/pull/98#issuecomment-863552910, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARK5J3KQOQF2RNDDZ3OJFZTTTJNNFANCNFSM464LM67Q.

GabrielF98 avatar Jun 17 '21 20:06 GabrielF98

No - you removed the change on the logbook (what is relevant), but unwanted files are still there (see the tab Files changed). You could do:

# remove from index unnecessary files
git rm --cached .DS_Store
git rm --cached  "machine-learning-1/Dimensionality Reduction.ipynb"
git rm --cached  "machine-learning-2/Validation and Optimization.ipynb"

git commit -m "remove unwanted files"

# add your contribution to the logbook (assuming you still have the changes)
git add participants_logbook.md

# commit and push
git commit -m "Add my contribution to the logbook"
git push

JulienPeloton avatar Jun 17 '21 21:06 JulienPeloton

Ok Ive run those how does it look at your end now?

Sorry about this and thanks for your help Julien

On 17 Jun 2021, at 22:03, Julien @.***> wrote:

No - you removed the change on the logbook (what is relevant), but unwanted files are still there (see the tab Files changed). You could do:

remove from index unnecessary files

git rm --cached .DS_Store git rm --cached "machine-learning-1/Dimensionality Reduction.ipynb" git rm --cached "machine-learning-2/Validation and Optimization.ipynb"

git commit -m "remove unwanted files"

add your contribution to the logbook (assuming you still have the changes)

git add participants_logbook.md

commit and push

git commit -m "Add my contribution to the logbook" git push — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/escape2020/school2021/pull/98#issuecomment-863561763, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARK5J3O4VJ5LAXCTHZ672ADTTJPKNANCNFSM464LM67Q.

GabrielF98 avatar Jun 17 '21 21:06 GabrielF98

No - the unwanted files are still there, and your contribution to the logbook is no more here.

JulienPeloton avatar Jun 17 '21 21:06 JulienPeloton