Eryk Sun

Results 42 comments of Eryk Sun

Off-topic comment: The library's [`SendSignal()`](https://github.com/alexrp/system-terminal/blob/v0.6.15/src/core/Terminals/Windows/WindowsVirtualTerminal.cs#L84-L96) method is flawed. [`GenerateConsoleCtrlEvent()`](https://docs.microsoft.com/en-us/windows/console/generateconsolectrlevent) takes a process group ID, or group 0 for all processes in the console session (including the calling process). The only...

> the primary challenge seemed to be interpreting KEY_EVENT_RECORDs correctly. That's why I suggested the addition of `PeekConsoleW()`, so applications wouldn't have to guess at what `ReadConsoleW()` would return, or...

> API to [map `SIGTERM` to `CTRL_SHUTDOWN_EVENT`](https://github.com/dotnet/runtime/blob/79e40e35ce3e218ad2d81259572e462b56bfd807/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/PosixSignalRegistration.Windows.cs#L69-L93), so I decided to be consistent with that to avoid confusion. Their choices aren't bad. Mapping `CTRL_BREAK_EVENT` to `SIGQUIT` isn't without merit, since...

> I'm pretty sure this started happening at the point where Python started using the redirector executable for virtual environments, but my investigations led me to believe that we couldn't...

@barneygale, wouldn't this enhancement entail `WindowsPath` overriding the base `Path` implementations?

We can do like what you implemented for `os.path.realpath()`. Add a `strict=False` keyword-only parameter to `exists()`, `isfile()`, `isdir()`, `islink()`, and `isjunction()`. In strict mode it ignores only a select set...

Should `nt._exists()` and the others be modified to raise an exception that gets handled by a wrapper function such as `ntpath.exists()`? Or should we have a list of ignored error...

It seems that the installation failed to modify `PATH`. With the command line "python-3.12.0-amd64.exe /passive InstallAllUsers=1 AppendPath=1", Python 3.12 should have been installed in "C:\\Program Files\\Python312". Please verify that the...

@zooba > I suspect you've hit the Windows bug that duplicates the PATH entry for `WindowsApps` Note that the image shown is for the system `PATH`. (The "Path" variable in...

> Sorry to confuse you, I missed a parameter TargetDir="C:\Python312".So the complete command is like this `python-3.12.0-amd64.exe /passive InstallAllUsers=1 AppendPath=1 TargetDir="C:\Python312"` When I tested an update earlier, the installer updated...