erxes Fix any

Summary by Sourcery

Enhance type safety and code clarity by replacing 'any' with specific types across various components and modules. Refactor components to use more specific prop types and improve code readability by using named functions.

Bug Fixes:

Fix type definitions and replace 'any' with specific types across multiple files to improve type safety and code clarity.

Enhancements:

Refactor components to use more specific prop types instead of 'any', enhancing type safety and maintainability.
Improve code readability and maintainability by replacing inline functions with named functions in several components.

[!IMPORTANT] Enhance type safety and code clarity by replacing any with specific types and refactoring components across multiple files.

Type Safety Improvements:

Replace any with specific types like IUser, IField, IOption, etc., in multiple files including SelectWithSearch.tsx, Form.tsx, Stage.tsx, and others.

Update function parameters and return types to use more specific types instead of any.

Refactoring:

Refactor components and functions to improve readability and maintainability.

Use destructuring and default parameters where applicable.

Miscellaneous:

Minor style and formatting adjustments in various files.

Remove unused imports and variables.

^{This description was created by}^{for 25d8567380aee247e793bafc4553b4d5ebedf209. It will automatically update as commits are pushed.}

Nov 05 '24 03:11 ganbaaaa

Reviewer's Guide by Sourcery

This pull request focuses on improving type safety across the codebase by replacing any types with more specific TypeScript types. The changes include adding proper type definitions, fixing type errors, and refactoring code to use proper type annotations.

Updated class diagram for PluginConfig and related types

classDiagram
    class PluginConfig {
        actionForms: string
        activityLog: string
        automation: string
        customNavigationLabel: Base[]
        exposes: Map<string, string>
        extendSystemConfig: string
        carRightSidebarSection: string
        template: string
        color: string
        innerWidget: InnerWidget
    }
    class Base {
        text: string
        url: string
        component: string
        scope: string
        module: string
    }
    class InnerWidget {
        style: string
        url: string
        scope: string
        module: string
    }
    PluginConfig --> Base
    PluginConfig --> InnerWidget

Updated class diagram for IField and related types

classDiagram
    class IField {
        _id: string
        contentType: string
        type: string
        options: List<string>
        groupId: string
        description: string
        isDefinedByErxes: boolean
    }
    class IFieldGroup {
        _id: string
        name: string
        fields: List<IField>
    }
    IFieldGroup --> IField

Updated class diagram for IUser and related types

classDiagram
    class IUser {
        isSubscribed: boolean
        isShowNotification: boolean
        customFieldsData: ICustomField
    }
    class ICustomField {
        // Custom fields structure
    }
    IUser --> ICustomField

Updated class diagram for ICoordinate and related types

classDiagram
    class ICoordinate {
        longitude: string
        latitude: string
    }
    class IContactInfo {
        phoneNumber: string
        email: string
        links: IUserLinks
        coordinate: ICoordinate
        image: IAttachment
    }
    IContactInfo --> ICoordinate

File-Level Changes

Change	Details	Files
Replace generic 'any' types with specific TypeScript types across multiple components and modules	Add proper type definitions for plugin configurations and navigation components Replace generic 'any' types with specific interface types for user, activity log, and form related components Add proper type definitions for query responses and mutation types Fix type errors in component props and state definitions	`packages/core-ui/src/pluginUtils.tsx` `packages/core-ui/src/modules/layout/components/navigation/types.ts` `packages/core-ui/src/modules/forms/types.ts` `packages/core-ui/src/modules/auth/types.ts`
Improve type safety in form and component handlers	Add proper typing for form event handlers and callbacks Implement proper type checking for component props Add type definitions for form values and submission handlers	`packages/core-ui/src/modules/forms/components/Properties.tsx` `packages/core-ui/src/modules/settings/team/components/common/ContactInfoForm.tsx` `packages/core-ui/src/modules/settings/profile/components/EditProfileForm.tsx`
Refactor board selection components to use proper type definitions	Create type-safe board selection rendering logic Add proper typing for board selection props Implement consistent board type handling across different modules	`packages/plugin-riskassessment-ui/src/components/common/BurenSection.tsx` `packages/plugin-grants-ui/src/cards/ActionComponent.tsx` `packages/plugin-goals-ui/src/components/goalForm.tsx`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Nov 05 '24 03:11 sourcery-ai[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Nov 05 '24 03:11 coderabbitai[bot]

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
899469	Triggered	Generic Password	b22c3a2370e2a2876abc31d60732f469c07f04c5	packages/core-ui/src/modules/layout/styles.ts	View secret
14169203	Triggered	Generic Password	4c784d81805f1578ca529740cba6910643d0d79b	scripts/create-plugins-saas-cis.js	View secret
14169204	Triggered	Username Password	4c784d81805f1578ca529740cba6910643d0d79b	scripts/create-plugins-saas-cis.js	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}