SaltGUI icon indicating copy to clipboard operation
SaltGUI copied to clipboard

Update the code to better handle the dropdown menus

Open erwindon opened this issue 5 years ago • 8 comments

Is your feature request related to a problem? Please describe. The current "checkbox-button" style menu and the "radio-button" style menu's have very dirty implementations. Both can be found in the command-box.

Describe the solution you'd like This should be cleaned up. Best solution seems to be the introduction of a "DropDownCheckbox" and "DropDownRadio" sub-classes that handle all the specifics.

Describe alternatives you've considered

  1. Leave it like this.
  2. switch to a gui toolkit that has this available.

Additional context Additionally, the difference between the user's choice and the system's choice in the "target" menu should be enhanced.

Additionally, the dropdown menu's should work on touchscreens. i.e. the menu opens on 'click' instead of only 'mouseover'.

erwindon avatar Aug 11 '20 18:08 erwindon

User's choice will be marked with ⚫ when present System default will be marked with ⚪ when no user's choice exists

erwindon avatar Oct 16 '20 13:10 erwindon

build completed TODO: simplify _updateTableFilter to remove sonarcloud issue TODO: more testing

erwindon avatar Apr 18 '22 19:04 erwindon

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 06 '22 19:10 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 14 '22 01:11 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.8% 1.8% Duplication

sonarqubecloud[bot] avatar Sep 17 '23 16:09 sonarqubecloud[bot]