Erwan Pannier

Results 286 comments of Erwan Pannier

hello @Yuhao-9509 ,see this discussion https://github.com/radis/radis/767 about the role of neighbour_lines. Setting it to the same value as the truncation is a consistent choice. also note that larger truncation does...

nice. can you add some screenshots of the results in the core PR text?

thanks for your contributions and critical thinking. A few insights on how to make the decision here : Radis is not a plotting library, nor a common interface to Plotly+Matplotlib....

Some tests are failing in `test\io\test_exomol\test_calc_exomol_vs_hitemp()` ![image](https://github.com/radis/radis/assets/16088743/93b46940-1096-449c-8531-49d84b270b32) There is clearly a problem here; and it is not related to broadening : the areas are not the same - either there...

@dcmvdbekerom you're right it's very related; and also we now need different environments (with/without) vaex depending on python version. Conda is not designed for optional dependencies (https://github.com/conda/conda/issues/12098) @minouHub all tests...

Thanks @ddelange for the suggestion. We're using Vaex for IO operations (read/write HDF5 files), and more recently for some internal calculations. It seems Polar does not support HDF5 yet (https://github.com/pola-rs/polars/issues/3520)...

(last test seemed good and failed for connection reasons, I restarted the build from Travis)

For information @minouHub @dcmvdbekerom Vaex support for Python 3.11; 3.12 was merged https://github.com/vaexio/vaex/pull/2331 We should keep Vaex optional as is done now; but can be the default for Python up...

AFAIK the current implementation has rovibrational spectra of electronic transitions , but no electronic temperature , and no non-equilibrium