openbrokerapi
openbrokerapi copied to clipboard
Missing ErrorMessage, ResponseError and description in K8s status
Describe the bug When raising a ErrBadRequest Exception with Message "Some Message" within a provisioning kubernetes will not show the Message "Some Message". Also ErrorMessage and ResponseError is "< nil >".
Example:
conditions:
- lastTransitionTime: "2022-04-22T09:06:57Z"
message: 'Error provisioning ServiceInstance of ServiceClass (K8S: "space1/s3"
ExternalName: "space1/s3") at ClusterServiceBroker "s3-broker":
Status: 400; ErrorMessage: <nil>; Description: The request data is invalid.;
ResponseError: <nil>'
reason: ProvisionCallFailed
status: "False"
type: Ready
...
To Reproduce Steps to reproduce the behavior:
-
svcat provision serviceinstance1 --class s3 --plan simplewhich raises a ErrBadRequest("Some Message") during Provisioning. -
kubectl get serviceinstance serviceinstance1 -o yamland see that ErrorMessage and ResponseError is nil. Also the message "Some Message" is missing.
Expected behavior
- If Exception ErrBadRequest("Some Description", "Some Error Message", "Some ResponseError") is raised during provisioning I expect following error messages:
kubectl get serviceinstance serviceinstance1 -o yaml
...
status:
asyncOpInProgress: false
conditions:
- lastTransitionTime: "2022-04-22T09:06:57Z"
message: 'Error provisioning ServiceInstance of ServiceClass (K8S: "space1/s3"
ExternalName: "space1/s3") at ClusterServiceBroker "s3-broker":
Status: 400; ErrorMessage: Some Error Message; Description: Some Description;
ResponseError: Some ResponseError'
reason: ProvisionCallFailed
status: "False"
type: Ready
...
I just saw that ErrInvalidParameters Exception exists. This accepts a msg parameter which should be passed to the description output. Why having ErrInvalidParameters and ErrBadRequest ? ErrInvalidParameters seems only returns a 40X Error on provisioning and updating.