Radek Szymczyszyn

Results 186 comments of Radek Szymczyszyn

``` =case sm_SUITE:resend_unacked_after_resume_timeout =logfile sm_suite.resend_unacked_after_resume_timeout.html =started 2015-08-19 10:01:46 =ended 2015-08-19 10:01:47 =result failed: {{badmatch,false}, [{escalus_session,stream_resumption,3, [{file,"src/escalus_session.erl"},{line,238}]}, {escalus_connection,connection_step,2, [{file,"src/escalus_connection.erl"},{line,119}]}, {lists,foldl,3,[{file,"lists.erl"},{line,1248}]}, {escalus_connection,start,2, [{file,"src/escalus_connection.erl"},{line,105}]}, {sm_SUITE,resend_unacked_after_resume_timeout,1, [{file,"sm_SUITE.erl"},{line,513}]}, {test_server,ts_tc,3, [{file,"test_server.erl"},{line,1360}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,977}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,925}]}]}, [{escalus_session,...

``` =case mam_SUITE:offline_message =logfile mam_suite.offline_message.html =started 2015-08-19 09:58:03 =ended 2015-08-19 09:58:05 =result failed: {test_case_failed, "ASSERT EQUAL\n\tExpected \n\tValue \n"}, [{mam_SUITE, offline_message, 897}, {test_server, ts_tc, 1360}, {test_server, run_test_case_eval1, 977}, {test_server, run_test_case_eval, 925}]...

``` =case mam_SUITE:offline_message =logfile mam_suite.offline_message.978381.370.html =started 2015-08-19 09:59:41 =ended 2015-08-19 09:59:42 =result failed: {test_case_failed, "ASSERT EQUAL\n\tExpected \n\tValue \n"}, [{mam_SUITE, offline_message, 897}, {test_server, ts_tc, 1360}, {test_server, run_test_case_eval1, 977}, {test_server, run_test_case_eval, 925}]...

Nice idea! However, I have a hunch it would be a bit misleading if `connection_steps` was reused in such a way, since the name suggests it's a list/group of things....

Specifically, [`maybe_stream_management `](https://github.com/esl/escalus/blob/e7b3c87efe2204d925927f9385db37e41d61eb6d/src/escalus_session.erl#L214-L221) could have one more case clause for the new value of the option.

@bartekgorny Could you link some usage example of the new API? Apart from the line comment about lists vs binaries above, there's already a way to set the resource, but...

I'm not against extending the API in general, but I'd like not to extend it by adding quirks and hacks for special cases - rather by exposing generic interfaces. To...

Thanks for the report! From a quick look it seems we're missing a clause for used-defined guards. We'll take a look at this.

https://github.com/esl/gradient/issues/145#issuecomment-1322441536 seems to be related.

Thanks, @eksperimental, good catch! The Elixir `if` is compiled to an Erlang `case` and it seems something is too quirky in the resulting code to be type checked properly. Marking...