ersilia icon indicating copy to clipboard operation
ersilia copied to clipboard

Test and workflows to check readme file changes on master

Open sayantani11 opened this issue 2 years ago • 12 comments

Fixes #177

sayantani11 avatar Apr 10 '22 17:04 sayantani11

I am looking into the error but what I feel is since the superior branch is named 'master', the issue arises as it works for a superior branch named 'main'

sayantani11 avatar Apr 10 '22 17:04 sayantani11

Hi @sayantani11 this is great stuff. Do you think we should rename master to main? (master is old nomenclature in github as you may know). I am afraid of doing so at this stage because many people are currently contributing to ersilia and this may cause problems. What are your thoughts?

miquelduranfrigola avatar Apr 11 '22 06:04 miquelduranfrigola

Hi @sayantani11 this is great stuff. Do you think we should rename master to main? (master is old nomenclature in github as you may know). I am afraid of doing so at this stage because many people are currently contributing to ersilia and this may cause problems. What are your thoughts?

Yes, it can create a chaos for the people who are new to git as well. So what I feel is we can hold this for now!! And after 20th we can focus on renaming the branch for this.... As it will be just two more days of the contribution period. What say?

sayantani11 avatar Apr 11 '22 10:04 sayantani11

Completely agree with you. Let's keep this on hold

miquelduranfrigola avatar Apr 11 '22 11:04 miquelduranfrigola

@miquelduranfrigola Can you rename the branch?

sayantani11 avatar Apr 19 '22 13:04 sayantani11

Hi @sayantani11,

We are making some changes to the repository structure, including creating a Docker image for it, so we will rename the branch when we release all these new features. Then we will merge the PR as well. Sorry this cannot be merged at this moment but many thanks for the work you have done, it will get merged hopefully next week!

GemmaTuron avatar Apr 22 '22 08:04 GemmaTuron

@GemmaTuron this pull request is very interesting. Can we please try to merge it, or at least learn the relevant GitHub Actions contributed?

miquelduranfrigola avatar Aug 19 '22 18:08 miquelduranfrigola

@GemmaTuron any progress here?

miquelduranfrigola avatar Sep 06 '22 21:09 miquelduranfrigola

@GemmaTuron I am trying to resolve this issue but I am running into conflicts at the moment. Can you please check?

miquelduranfrigola avatar Oct 06 '22 21:10 miquelduranfrigola

Hey, since @sayantani11 is participating in this round, this might be a good moment to close the issue. @miquelduranfrigola and @sayantani11 I get an error on the Setup of the pull request that says "Error: The log was not found. It may have been deleted based on retention settings."

GemmaTuron avatar Oct 10 '22 09:10 GemmaTuron

@GemmaTuron @miquelduranfrigola I can actually look into this issue again! And try to figure what's the problem maybe

sayantani11 avatar Oct 10 '22 09:10 sayantani11

Sorry, I overlooked this PR - my apologies. @sayantani11 is doing amazing work on other fronts. So, @sayantani11 - if you have time to work on it, great. If not, I would deprioritise this PR for now.

miquelduranfrigola avatar Oct 20 '22 11:10 miquelduranfrigola