GameFinder icon indicating copy to clipboard operation
GameFinder copied to clipboard

EADesktop games can be missing a BaseSlug entry (e.g., Knockout City)

Open Nutzzz opened this issue 1 year ago • 2 comments

  • Instead look for DisplayName in the registry (from installInfo.ExecutableCheck), and fall back to installInfo.BaseSlug only if necessary.
  • Also discard DLCs.

Nutzzz avatar May 24 '23 01:05 Nutzzz

Can you provide a decrypted JSON file for reference?

erri120 avatar May 24 '23 08:05 erri120

Note the dlcSubPath check works for the Battlefield 4 DLCs but not the Sims 4 DLCs (I added this check in my fork before I acquired Sims 4). You can use the executableCheck (between the registry entry in square brackets and the existence of the specified file) to determine whether a base game is installed; unlike installCheck, DLCs won't have this populated. This doesn't distinguish DLCs from owned not-installed base games. However, for modding purposes I don't think that matters, since you'd likely want to discard not-installed games anyway.

On the other hand, I imagine knowing whether a given DLC is installed would be helpful for modding, so perhaps adding installCheck would be helpful, and then between that and executableCheck you'd know whether a given installed game is a DLC or not. EDIT: Of course, you'd probably want to add an IsBaseGame or IsDLC to EADesktopGame (and perhaps IsInstalled as well, if for some reason you do want the not-installed games).

Nutzzz avatar May 24 '23 17:05 Nutzzz