usb-canary icon indicating copy to clipboard operation
usb-canary copied to clipboard

usb-canary will exit due to errors

Open jaseg opened this issue 8 years ago • 2 comments

In several places, usb-canary will quietly exit depending on external conditions. One such place is the twilio message handler. If a mere network error occurs, it will quietly exit.

  • [ ] Feature Request
  • [x] Bug Report

Expected Behavior

When a messaging channel is configured and errors occur, usb-canary should asynchronously retry as many times as necessary to send the message. Under no conditions should failure of one messaging channel prevent other intact channels from working.

Current Behavior

If e.g. twilio and slack are enabled, and the twilio code raises an error, usb-canary will exit without even attempting to use slack.

Possible Solution

Handle all messaging asynchronously with appropriate back-off.

Steps to Reproduce (for bugs)

Context

usb-canary at least on first glance looks like a security tool. Thus it should be secure.

Your Environment

This is independent of operating system.

jaseg avatar Oct 08 '17 11:10 jaseg

Hi @jaseg,

Thanks for submitting an issue, this has been put into the roadmap. Again thanks for taking the time to contribute to USB Canary.

errbufferoverfl avatar Oct 08 '17 23:10 errbufferoverfl

Along with other improvements referenced in other issue comments, I am currently working on better error handling where possible, a number of improvements have been made, including using a different daemon which will allow - in case of failure of other logging mechanisms - logging to at least be done.

errbufferoverfl avatar Jan 19 '18 03:01 errbufferoverfl