errbot icon indicating copy to clipboard operation
errbot copied to clipboard

IRC backend doesn't render cards correctly

Open harlowja opened this issue 9 years ago • 6 comments

Not everyone uses mIRC so we shouldn't default to the format that only works with it (because thats not exactly a friendly output for other IRC client users),

For example here is a output from hexchat:

<gerritbot2>  {: color='black' bgcolor='green' }
<gerritbot2> Kyrylo Galanov ([email protected]) proposed change Fix race condition in get puppet status at https://review.openstack.org/335319 in project openstack/fuel-astute (+1|-1).
<gerritbot2>    ()

harlowja avatar Jun 30 '16 04:06 harlowja

hmmm it doesn't look like mIRC color codes, is this a template that somehow doesn't work ?

gbin avatar Jul 02 '16 00:07 gbin

Template is @ https://github.com/harlowja/gerritbot2/blob/master/plugins/gerritbot/templates/proposal.md so I don't think so.

harlowja avatar Jul 02 '16 04:07 harlowja

Maybe this is coming from a card before this message ? https://raw.githubusercontent.com/errbotio/errbot/master/errbot/templates/card.md ? (it looks more like a bug in the markdown of a card under IRC)

gbin avatar Jul 02 '16 05:07 gbin

Ya, that could be it.

harlowja avatar Jul 02 '16 05:07 harlowja

How does one turn off that template from being used for IRC?

harlowja avatar Jul 02 '16 18:07 harlowja

This card template is more little a stop gap if a backend doesn't have a send_card function (like slack, hipchat etc have). Maybe the correct way to fix this is to implement it for IRC ?

gbin avatar Jul 02 '16 18:07 gbin