vale-action icon indicating copy to clipboard operation
vale-action copied to clipboard

Action never failed even if error level issues are detected & fail_on_error is set to true

Open fharper opened this issue 2 years ago • 2 comments

I have the level set to error for my custom vocab, and substitution. When running the GitHub Action, vale report the issues with the proper error level. I also have fail_on_error set to true. No matter these, the action always succeed, and never fail. Here's the .vale.ini for reference.

I assume I either miss something, didn't use the argument properly or it's a bug. Any idea what is happening here?

fharper avatar Jul 19 '23 16:07 fharper

@jdkato any idea?

karl-johan-grahn avatar Aug 11 '23 22:08 karl-johan-grahn

Seems like it may be a reviewdog issue, and not vale since it's a reviewdog option.

If I'm not wrong, you can close this issue. I posted my workaround in the reviewdog issue https://github.com/reviewdog/reviewdog/issues/1408

fharper avatar Aug 23 '23 22:08 fharper