errael

Results 101 comments of errael

I copied `FileChooserBuilder.findDialogParent()` into a standalone app. In practice it has much better characteristics than simply using the main window (at least in my tests using `JOptionPane(findDialogParent(),...)` from a dialog)....

I'm just taking another look at `DialogDisplayerImpl`. I may have unfoundedly disparaged `KeyboardFocusManager` returns; I had thought that perhaps it was being called when the focus owner was not in...

> manual pass Using `findDialogParent`, which is needed anyway since not all the classes in question meet the criteria, there's good odds that the `Component` in question is the focusOwner...

> maybe also consider reducing the whitespace changes in the imports Yeah, I need to run it again anyway, I can turn off `Separate groups` in editor > formatting.

@neilcsmith-net, put findDialogParent in DialogDisplayer as static method. Instance method didn't make sense, it's not part of a NetBeans dialog. Upgraded PR from draft. ApiChanges updated.

> wonder if that method should just go in `Utilities`? I'm OK with that. Wanted to pick something to get the ball rolling... When I was looking for a Util...

> looking at changes in https://github.com/apache/netbeans/pull/4714 I wonder if that method @neilcsmith-net, Oh, wait. I may have misunderstood. Is your comment about ` getPreferredScreen()` or `findDialogParent()`?

Took me a while to realize that #4714 was the same Utilities.java that `findDialogParent()` is moving to. (I miss my system) > `FileChooserBuilder` to use it too? I think the...

Wow, there are 49, as of a recent count, `Utilities.java` in the tree. It's looking like the system won't be back from the shop till later in the week, so...

Too bad using _add module dependency_ doesn't preserve the file line endings.