Performance drop for pefile.PE()

[mschwoer]

Hi!

After upgrading from 2023.2.7 to 2024.8.26 the calls to pefile.PE() done by pyinstaller==6.10.0 take considerably longer on a Windows github action runner. This is observed in pyinstaller's "Performing binary vs. data reclassification" step, which takes orders of magnitudes longer now.

logs: 2023.2.7: https://github.com/MannLabs/alphapeptdeep/actions/runs/10524645976/job/29161830971 "reclassification" step takes 3s

rerunning the same exact job through the github UI today pulled the latest version of pefile: 2024.8.26: https://github.com/MannLabs/alphapeptdeep/actions/runs/10524645976/job/29307704805 (reclassification step is still in progress at time of writing this ;-))

similar job with some extra debug logs in pyinstaller (proof that is the actual call to pefile.PE() for each single file): https://github.com/MannLabs/alphapeptdeep/actions/runs/10578467189/job/29308669020

similiar job with downgrade to pefile==2023.2.7 (proof that 2024.8.26 is the root cause): https://github.com/MannLabs/alphapeptdeep/actions/runs/10578920267/job/29310144178

happy to share any more details if required..

best, Magnus