Ero Carrera
Ero Carrera
Hi, if you have a use for such functionality, feel free to send a PR. I would avoid the "is valid PE" naming. I feel like saying that a PE...
Hi, when you say "loaded correctly", what is the end result you expect? The line is part of the code of the `get_memory_mapped_image()` method. The large `section.SizeOfRawData` imply the section...
The code in this PR modified the functionality of `update_if_sum_is_larger_and_within_file()` in an incompatible way. The file you point to appears to be corrupt/truncated. Sections are either bigger than the total...
Thank you @pombredanne for the amazing work of putting together such a test suite. I am now using it as part of a GitHub Action to run tests, something I...
I want to understand better what is the reason for this change? does it mirror the behavior of the OS or is it simply to keep it "clean" of the...
This change does not correctly handle the mapped data so far.
Hello, that would be great. It's always good to have cases for the test suite. But I was talking more about the PR, the code appears to simply take the...
Just changing the initial contents of "mapped_data" should lead to the behavior you desire. I've made the change in commit 14a4c71. What do you think?
Yes, out of curiosity I ran over all the files I use for my tests and there are a few with negative `padding_length`, both when encountering the first section and...
I do have push access to https://github.com/erocarrera/pydot anybody wants to jump in? let me know if I need to point pydot in pypi to a working fork or if anybody...