Ernesto Revilla

Results 49 comments of Ernesto Revilla

Suggestions on how to treat this? Using some error treatment hook would be nice. El 19 sept. 2018 12:43 p. m., "sheepsy90" escribió: Actually when looking at the raw data...

Hi. Find attached zip file with signatures: * test_cades-bes_implicit.csig: CADES BES Implicit * test_cades-epes_explicit.csig: CADES EPES Explicit * test_cades-a_explicit.csig: CADES EPES Explicit converted to CADES-A [test_cades_signatures.zip](https://github.com/wbond/asn1crypto/files/842943/test_cades_signatures.zip)

I'm trying to implement it but have some questions: * How do I specify strings with maximum length? e.g.: DisplayText ::= CHOICE { visibleString VisibleString (SIZE (1..200)), bmpString BMPString (SIZE...

I also found that there may be some small errors in [RFC 5126](https://tools.ietf.org/html/rfc5126) when defining SigPolicyQualifierInfo. Pages [37](https://tools.ietf.org/html/rfc5126#page-37) and [72](https://tools.ietf.org/html/rfc5126#page-72) define the member as `sigQualifier` but page [80](https://tools.ietf.org/html/rfc5126#page-80) define the...

Still work in progress, but I completed translating all CMS Attributes. If anyone finds the time, please check if the names follow naming conventions. I use extensively "SetOf..." form CMSAttributes...

Hi. Thanks a lot for your review. All cms attributes have already underscored names, but other structures use field names as they appear in RFC spec. But it's not a...

Basically, I have a working version and for analyzing signatures it may be a good enough starting point. I have some basic tests included. I'll submit a pull request.

Reviewing [RFC 5652](https://tools.ietf.org/html/rfc5652#section-5.3) explains that: SignedData ::= SEQUENCE { version CMSVersion, digestAlgorithms DigestAlgorithmIdentifiers, encapContentInfo EncapsulatedContentInfo, certificates [0] IMPLICIT CertificateSet OPTIONAL, crls [1] IMPLICIT RevocationInfoChoices OPTIONAL, signerInfos SignerInfos } In other...

Interesting. Could you suggest an interface to do that? My tests do something like this: with open(os.path.join(fixtures_dir, 'cades-bes-implicit.der'), 'rb') as f: info = cades.ContentInfo.load(f.read()) self.assertEqual( 'signed_data', # type signed_data info['content_type'].native...

The Circleci job failed, but it seems unrelated to the commits.