Ernie Miller

Deep integration with ActiveRecord has broken better men and women than me. Godspeed and good luck, @bmulholland.

@gamov looking at the sample queries I'm gonna guess it just monkey-patches the (ill-advised) WhereChain class to add `has`. Back when I built Squeel, the intent (as had been indicated...

@mnoack I'm happy (depending on the current maintainers' feelings) to place a reference to @rzane's project, if other maintainers don't wish to continue to maintain it. As for me, I...

Correct.That's intentional, though. Not really sure what the desired outcome would be on this one?

I don't see any tests for this fix -- how are you managing to push a Squeel join node through to build_join_dependency? Can you show a use case that fails...

:-1: on this. AR maps Base#id to whatever the primary key is.

Monkey patching Squeel which monkey patches ActiveRecord which monkey patches everything hardly seems like a sustainable path forward for your app/library.

@bigxiang FWIW, I'm not a fan of merging these kinds of alternative-Ruby fixes if they're for a bug in the interpreter. The change here (calling `break`) is very odd-looking for...

Probably reasonable to include the operators on the sifters. I am trying to think of a situation in which (apart from a stylistic opposition to unnecessary parens) a user would...

Bah. Good call, @the8472. So, I'd say the better option really would be to simply wrap the sifter in a grouping node inside the Squeel DSL itself, and do whatever...