M. Ernestus

Results 89 comments of M. Ernestus

The remaining failing test is for `benchmark_and_table.sh`. It fails since it calls `bc_benchmark.sh` with the `--paper` option. This will try to train a `seals_half_cheetah` policy which fails since mujoco has...

Not sure why the coverage suddenly dropped in a totally unrelated file. The naive solution which would be just running a config of preference comparisons with the `active_selection` flag set...

> Also one test is failing on Mac OS (maybe flaky? I don't see anything Mac OS specific) Me neither. It definitively is one of the flaky tests. Should probably...

> And type checking failing Yep, thanks for the hint. That fixed it.

> I'm a bit unsure about adding some of the additions `imitation.testing`. It seems best to reserve this for generally useful methods, that will either be used across multiple files...

I moved the data loader back to `test_bc.py`. The test is only flaky on the MacOS runner. So this will take some more time to investigate since I don't have...

I vote for giving `pre-commit` a try. I think it looks interesting and it could replace `ci/code_checks.sh` with something far more concise while potentially checking for far more corner cases...

I played around with it and came up with the following `.pre-commit-config.yaml`: ```yaml # See https://pre-commit.com for more information # See https://pre-commit.com/hooks.html for more hooks repos: - repo: https://github.com/pre-commit/pre-commit-hooks rev:...

I am having the same issue.

@magjack I could not figure out what `RacingEnv` you used. Can you give me a hint? Also if I had the files you are loading that would be immensely helpful...