shout icon indicating copy to clipboard operation
shout copied to clipboard

Request for notification approval on page load if the setting is enabled

Open xPaw opened this issue 9 years ago • 5 comments

Currently you can have to disable/enable the setting to get the "page is asking for notification access" popup.

xPaw avatar Jan 30 '16 20:01 xPaw

Why would we ask for permission when the user hasn't asked us to show them notifications yet?

AlMcKinlay avatar Jan 31 '16 06:01 AlMcKinlay

The problem is that the notifications are enabled by default in Shout's settings, so the behaviour is quite inconsistent.

xPaw avatar Jan 31 '16 11:01 xPaw

Wait, are they? I thought badge was set to false by default.

AlMcKinlay avatar Jan 31 '16 16:01 AlMcKinlay

That's interesting. It is indeed badge: false in the code. I guess I clicked close button some time ago when it asked for notifications.

xPaw avatar Jan 31 '16 16:01 xPaw

Ah yes, that does bring up another bug. If you choose to enable the notification setting, but don't accept notifications, then you have to disable it and enable it again before you get asked again. We should probably think of a solution to that.

AlMcKinlay avatar Jan 31 '16 16:01 AlMcKinlay