erming
use npid for pid file support
as per: https://github.com/erming/shout/pull/379#issuecomment-165039111
--silent is useful in a cron job script, like this one I use, in order to prevent repeated log entries about failing to create the pid file
#!/bin/bash
if [ -z $(ps -p $(cat ~/.shout/shout.pid) -o pid=) ]; then
rm -f ~/.shout/shout.pid
fi
node /home/shout/shout/index.js --silent >> /home/shout/shout.log 2>&1 &
I run the above script with cron every minute in order to check for stale pid files, and then try and start shout.
The stale file check is important, because although the file should be removed on a crash, if the process is killed (SIGKILL), or the server itself crashes, you can be left with a stale pid file which would prevent shout from starting.
--silent is useful in a cron job script, like this one I use, in order to prevent repeated log entries about failing to create the pid file
In which cases would that occur ?
@apmorton thanks a lot for your contrib and sorry for my ashamingly-high delay on the review, I will try to be more reactive on the discussion :-)
If you notice in my example cron script, I always attempt to start shout - I do not check for the existence of the pid file to control starting shout. Perhaps --silent is not required, because you could implement additional checks in the cron job itself before attempting to launch shout.
if shout is already running with the same pid file, and you try to launch it again, you get a pid file creation error message. --silent suppresses this
~~correct me if I am wrong, but systemd daemons can only be configured system-wide, by a root user.~~ I am wrong
With a generic pidfile approach, any user can configure shout without needing to be root.
that being said, I don't know much about systemd, which is why it was not my preferred solution.
TL;DR; pidfiles work - so does systemd, something about skinning a cat
Do we want to have to maintain everything about OS integration?! I mean, we have a Dockerfile, this would add npid information to the config file. I also noticed someone PRing for forever, there were mentions of systemd, ... I personally use supervisor but I don't want to add supervisor configuration in shout's git repo (since it's personal, I maintain it personally here: https://github.com/astorije/ansible-role-shout). What about Homebrew then? Or Windows installers?
I'd rather see this repo and project about and shout itself and its features, and let the community come up with integration projects. When some of these reach a nice stable point, we can deem them official if needed.
@apmorton, would it be possible to have this in a repo you control and maintain? Then we can list interesting integration projects in a wiki page, the documentation repo and/or website, ...
What do you guys think?
I think having pidfile support is pretty OS agnostic...
In any case, I sent this PR at the request of @JocelynDelalande https://github.com/erming/shout/pull/379#issuecomment-165039111
Do we want to have to maintain everything about OS integration?! I mean, we have a Dockerfile, this would add npid information to the config file. I also noticed someone PRing for forever, there were mentions of systemd, ... I personally use supervisor but I don't want to add supervisor configuration in shout's git repo (since it's personal, I maintain it personally here: https://github.com/astorije/ansible-role-shout). What about Homebrew then? Or Windows installers?
Offering some decent, light and cross-system PID writing mechanism does not hurt, IMHO, and some init system can integrate of a program that writes its pid to a file itself.
About installers, that's a different question, as we already offer a preferred and cross-OS way : npm installation.
About supporting various init systems (although I think that's not what we should be discussing here), I'm not against a contrib dir including systemd/runnit/OSXinit/whatever init scripts. I do agree that it's something more to maintain, but I'm also sure that it's an important thing for a server software, and we better keep an eye on it (+ it's realy light : one text file for each init system).
What do you guys think?
To sum it up, the pid file creation (this PR) does not goes as far as an init system but allows easier management/scripting around it.
@apmorton I pause technical discussion till we agree on whether or not the feature itself has an interest.