shout
shout copied to clipboard
add rough reconnection support
- this breaks currently when your nickname is already in use and I'm unsure why.
reference: issue #235
Does slate-irc not hook on nickname in use before receiving 001
?
don't merge this yet - there's a problem: the reconnection spawns exponential numbers of attempts simultaneously at each failed attempt.
@diddledan What's the status of this?
@diddledan, did you make any progress on this? I know @xPaw and @erming mentioned constant reconnection errors, maybe they can give their input here too?
@diddledan Any idea why it spawns exponential reconnection attempts? Does the error-handler fire multiple times per disconnect or something?
@edbrannin @diddledan I fixed exponential reconnection attempts and added reconnection on ping timeout - will upload working version soon.
P.S. "nickname is already in use" problem doesn't occur, already fixed?
@bews, just to let you know, development on Shout has become inactive, so it's likely that you will not get an answer to your question(s).
FYI, the officially supported fork The Lounge has active development around automatic reconnection support, see https://github.com/thelounge/lounge/pull/254. The reason why the fork's PR is much smaller than any attempt that could be made on Shout is because we recently switched to a different underlying library for IRC, and it aims to handle reconnection itself.
It's not quite there yet, but almost. I wanted to chime in to avoid duplicating similar work :-)
@astorije well, when I started working with Shout I didn't know about Lounge fork, so I'll stick with this one :)
I've modified a lot of things here, some of them will be uploaded soon.
Ok then! :-) Just know that the maintainers' team has moved to The Lounge so if you want to contribute, it's more likely that your work will be merged there.