jamdb_oracle icon indicating copy to clipboard operation
jamdb_oracle copied to clipboard

Warning with ecto_sql 3.9.x

Open winks opened this issue 2 years ago • 1 comments

Hi, I just updated to 0.5.2 (with Ecto 3.9.1) and there's a warning:

warning: function dump_cmd/3 required by behaviour Ecto.Adapter.Structure is not implemented (in module Ecto.Adapters.Jamdb.Oracle)
  lib/jamdb_oracle_ecto.ex:1: Ecto.Adapters.Jamdb.Oracle (module)

This is actually mentioned in the changelog: https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md#v390-2022-09-27 but of course that was released after 0.5.2

I didn't look deeper into the code, just thought I'd mention it.

winks avatar Oct 13 '22 13:10 winks

Unused behaviours can be removed. commit

vstavskyi avatar Oct 17 '22 12:10 vstavskyi