rebar3 icon indicating copy to clipboard operation
rebar3 copied to clipboard

Ensure provider hook calls don't crash because of invalid command line arguments

Open tolbrino opened this issue 4 years ago • 3 comments

Normally the CLI arguments are intended for the provider which is called directly. When these are forwarded to other providers through hooks things might break.

tolbrino avatar Aug 30 '19 13:08 tolbrino

This is a good fix, but we'll need to add a test for this before we merge it. This is core dispatching functionality we shouldn't change without repeatable validation.

ferd avatar Sep 01 '19 16:09 ferd

ping @tolbrino

tsloughter avatar May 11 '20 14:05 tsloughter

ping @tolbrino

I got blocked by trying to get a test working, but to no avail. I will take a look again some time later this week.

tolbrino avatar May 11 '20 15:05 tolbrino