erlang
kernel: Add option for erl_boot_server listen port
Implements start/2 and start_link/2 for erl_boot_server, which accept a map with configuration options.
The map key listen_port allows the configuration of the boot server listening port. If an empty map is provided, or the listen_port is zero, the old behavior is kept, i.e. an ephemeral port is used.
Requested in issue #7365.
CT Test Results
2 files 70 suites 1h 6m 11s ⏱️ 1 586 tests 1 332 ✅ 254 💤 0 ❌ 1 838 runs 1 526 ✅ 312 💤 0 ❌
Results for commit a4d459e2.
:recycle: This comment has been updated with latest results.
To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.
See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.
Artifacts
- Complete CT logs (Download Logs)
- HTML Documentation (Download HTML Docs)
- No Windows Installer found
// Erlang/OTP Github Action Bot
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jhogberg Thank you for reviewing. I addressed the changes in a new commit, but I can force push in the future, if you prefer. I will squash in the end regardless.
I also fixed some minor formatting issues in erl_boot_server_SUITE.erl. I'm not sure how strict the column limit is.
@jhogberg Added new commit. I'm available for further changes, thank you.
I think that covers it, I'll add it to our nightly builds as soon as it's squashed. :-)
@jhogberg Added new commit. I'm available for further changes, thank you.
I think that covers it, I'll add it to our nightly builds as soon as it's squashed. :-)
Done. Do you also need me to rebase onto current master?
@jhogberg Added new commit. I'm available for further changes, thank you.
I think that covers it, I'll add it to our nightly builds as soon as it's squashed. :-)
Done. Do you also need me to rebase onto current master?
Nah, so long as it merges cleanly there's no need for a rebase :-)