otp icon indicating copy to clipboard operation
otp copied to clipboard

crypto: Remove incorrect configure check for FIPS_mode_set

Open sverker opened this issue 1 year ago • 1 comments

Fix #8271

  • FIPS_mode_set does not exists since OpenSSL 3.x

  • The configure check with AC_CHECK_FUNC for FIPS_mode_set succeeds anyway on Linux as compiler accepts implicit declaration (with only a warning) and linker accepts undefined symbols as we build a shared lib.

  • Checking for FIPS_mode_set was pointless as it was available even for non-fips builds of OpenSSL 1.x

On MacOS however, the check "works" and thereby hinders building Erlang/OTP with --enabled-fips for OpenSSL 3.x.

sverker avatar Mar 18 '24 18:03 sverker

CT Test Results

  2 files   14 suites   6m 19s :stopwatch: 188 tests 173 :white_check_mark:  15 :zzz: 0 :x: 482 runs  318 :white_check_mark: 164 :zzz: 0 :x:

Results for commit 41bcb7f8.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Mar 18 '24 18:03 github-actions[bot]