otp icon indicating copy to clipboard operation
otp copied to clipboard

stdlib: fix some autocompletion bugs

Open frazze-jobb opened this issue 2 years ago • 3 comments

  • strip newlines after format_matches, we only want one
  • find_type should recognize {type, any, []} as the any type
  • functions with arity 0 and multiple other arities but without typespecs should output the function/0

frazze-jobb avatar Oct 04 '22 14:10 frazze-jobb

CT Test Results

       3 files     141 suites   1h 38m 49s :stopwatch: 3 062 tests 2 880 :heavy_check_mark: 181 :zzz: 1 :x: 3 555 runs  3 327 :heavy_check_mark: 227 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit c1b6d7f6.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Oct 04 '22 14:10 github-actions[bot]

If I do:

erl -stdlib shell_expand_location above
1> esc<TAB>
modules
escript:
1> escript:

the only completion is printed when it should just complete on the same line. Does this PR fix that? (The problem is also there for when expand is below, but just results in a blank expand area).

garazdawi avatar Oct 14 '22 12:10 garazdawi

nope, but I can add a fix for that

frazze-jobb avatar Oct 14 '22 12:10 frazze-jobb