otp icon indicating copy to clipboard operation
otp copied to clipboard

Add missing type specs in http client (httpc.erl)

Open kikofernandez opened this issue 2 years ago • 1 comments

This PR adds type specs to the API of the http_client app, file httpc.erl. I have updated the XML documentation to use the type specs from httpc.erland this fixes #6245

kikofernandez avatar Sep 14 '22 14:09 kikofernandez

CT Test Results

    2 files    21 suites   13m 20s :stopwatch: 334 tests 312 :heavy_check_mark: 21 :zzz: 1 :x: 558 runs  521 :heavy_check_mark: 37 :zzz: 0 :x:

For more details on these failures, see this check.

Results for commit 35dbbc0f.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Sep 14 '22 14:09 github-actions[bot]

I have removed the essl option from socket_type option creating a new wrapper that takes any ssl and replaces it by essl and vice versa. This wrapper must be in place until #6380 gets fixed.

kikofernandez avatar Oct 19 '22 13:10 kikofernandez

Closing PR to create one with the correct naming convention for OTP team

kikofernandez avatar Nov 08 '22 08:11 kikofernandez