otp icon indicating copy to clipboard operation
otp copied to clipboard

kernel: Fix Logger filter removal if message format is atom or binary

Open dmitrivereshchagin opened this issue 1 year ago • 1 comments

Log event check performed in logger_backend:do_apply_filters/4 doesn't tolerate atoms and binaries as message format strings. This may cause a filter to be removed

> logger:notice(<<"hello">>, []).
Logger - error: {removed_failing_filter,no_domain}

For atom format strings it was partially fixed in OTP 25 by forcing atoms to strings before filters are applied (17c8fcf).

dmitrivereshchagin avatar Aug 10 '22 20:08 dmitrivereshchagin

CT Test Results

       2 files       65 suites   57m 13s :stopwatch: 1 335 tests 1 202 :heavy_check_mark: 133 :zzz: 0 :x: 1 501 runs  1 338 :heavy_check_mark: 163 :zzz: 0 :x:

Results for commit f33c6d6c.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Aug 10 '22 20:08 github-actions[bot]

Thanks!

garazdawi avatar Aug 30 '22 08:08 garazdawi