otp icon indicating copy to clipboard operation
otp copied to clipboard

dialyzer: Use more compression in incremental PLTs

Open TD5 opened this issue 2 years ago • 4 comments

The incremental data portion of incremental PLTs was previously uncompressed, contributing to the considerable size of the PLT files which can accrue for big projects. This change compresses that field (whilst staying able to read PLTs whose file is uncompressed), which should help us save disk space and bandwidth when reusing incremental PLT files between users/hosts/commits.

This change also increases how hard Dialyzer "tries" to compress the contents, trading off speed for smaller file size. In practice, time spent doing compression/de-compression is negligable whatever the compression level, but with this higher compression level, PLT files work out ~5% smaller for projects I have experimented with.

TD5 avatar Aug 10 '22 10:08 TD5

CT Test Results

    2 files    37 suites   20m 43s :stopwatch: 446 tests 443 :heavy_check_mark: 3 :zzz: 0 :x: 532 runs  529 :heavy_check_mark: 3 :zzz: 0 :x:

Results for commit dfbdadbb.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Aug 10 '22 10:08 github-actions[bot]

Thanks for your pull request.

Please squash the commits.

bjorng avatar Aug 15 '22 11:08 bjorng

Please squash the commits.

Oops! Thanks, done.

TD5 avatar Aug 15 '22 14:08 TD5

Thanks! Added to our daily builds.

bjorng avatar Aug 15 '22 14:08 bjorng

Thanks @michalmuskala for your suggestion to try this

TD5 avatar Aug 16 '22 10:08 TD5