otp icon indicating copy to clipboard operation
otp copied to clipboard

inets: Allow the body of httpc:request/5 to be an iolist

Open artman41 opened this issue 2 years ago • 4 comments

artman41 avatar Jul 29 '22 01:07 artman41

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 29 '22 01:07 CLAassistant

CT Test Results

    2 files    21 suites   12m 34s :stopwatch: 333 tests 310 :heavy_check_mark: 22 :zzz: 1 :x: 556 runs  518 :heavy_check_mark: 38 :zzz: 0 :x:

For more details on these failures, see this check.

Results for commit fa0b92d7.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Jul 29 '22 01:07 github-actions[bot]

You do not need to update the version manually that will be done by our scripts when it makes into a patch/release.

IngelaAndin avatar Aug 11 '22 06:08 IngelaAndin

You do not need to update the version manually that will be done by our scripts when it makes into a patch/release.

Reverted the change to vsn.mk, please let me know if any other changes are needed :)

artman41 avatar Aug 15 '22 22:08 artman41

I think this pull request looks good

kikofernandez avatar Sep 16 '22 06:09 kikofernandez

@artman41 this is ready to be merged but, could you please rebase it on top of maint? I think this change makes more sense to be available before OTP 26 release. Thanks!

kikofernandez avatar Sep 16 '22 07:09 kikofernandez

@kikofernandez just rebased on to maint 👍

artman41 avatar Sep 19 '22 18:09 artman41

I will merge tomorrow if all tests are green. Thanks for your contribution @artman41 !

kikofernandez avatar Sep 22 '22 11:09 kikofernandez