inets: added missing required property server_name

[tonywallace64]

config file changed from apache format to erlang terms

Closes #5276

[CLAassistant]

All committers have signed the CLA.

[github-actions[bot]]

CT Test Results

    2 files    21 suites   11m 5s :stopwatch: 320 tests 296 :heavy_check_mark: 23 :zzz: 1 :x: 531 runs  492 :heavy_check_mark: 39 :zzz: 0 :x:

For more details on these failures, see this check.

Results for commit 865a5a10.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[IngelaAndin]

Hi, thank you for the PR. Could you please base it on maint so that it can be part of the OTP-25 track, this improvement I think should not be delayed until OTP-26!

[IngelaAndin]

You need to stand on your branch and do a rebase --onto maint HEAD~1

[u3s]

tony can you do some more adjustments in this PR or would you prefer if I take it over and do it?

Those are things I was thinking about:

1. rebase on latest erlang:maint
2. adjust the PR to target erlang:maint branch
3. squash your commits
4. solve conflict if still present

[tonywallace64]

Please do. I have rebased onto maint. However I put wrong PR request on pull. Rickard-green has added team:PS label two days ago. Screenshot attached.

There also remains the issue of ssl.conf example. I have converted the file but have not yet got it running. I could put that on my own github fork if it helps.

Tony

On Mon, 2022-06-20 at 11:12 -0700, Jakub Witczak wrote:

tony can you do some more adjustments in this PR or would you prefer if I take it over and do it?

Those are things I was thinking about:

rebase on latest erlang:maint adjust the PR to target erlang:maint branch squash your commits solve conflict if still present — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[u3s]

please push it to your fork. I will combine it when time allows. thanks for contribution.

[tonywallace64]

Okay, pushed new ssl.conf to master branch on my fork

On Tue, 2022-06-21 at 13:09 -0700, Jakub Witczak wrote:

please push it to your fork. I will combine it when time allows. thanks for contribution.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[u3s]

sorry to write this, but I've been busy with other tasks. This need to wait to little longer.

[tonywallace64]

I have just pushed some more conf files. I did not do the ssl one as a straight format conversion did not work so that will take a bit more work.

On Thu, 2022-06-16 at 07:06 -0700, Ingela Andin wrote:

You need to stand on your branch and do a rebase --onto maint HEAD~1

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[anupamasingh10]

Hi @tonywallace64, the conf files should look something like:

[{port,8080},
 {server_name,"your.server.net"},
 {socket_type,ip_comm},
 {modules,[mod_alias,mod_auth,mod_esi,mod_actions,mod_cgi,mod_dir,mod_get,
          mod_head,mod_log,mod_disk_log]},
 {server_admin,"[email protected]"},
 {server_root,"/var/tmp/server_root"} | ...].

Please let me know if you wouldn't be able to make these changes. I can continue with this then.

[IngelaAndin]

Closed in favor of #7079