erts: Apply -fno-omit-frame-pointer to erts/lib_src when JIT is enabled

[d1jang]

Currently OMIT_OMIT_FP is set to true in erts/emulator/Makefile.in when JIT is enabled, but not necessarily in erts/lib_src/Makefile.in.

This change factors out OMIT_OMIT_FP computation to be shared between those two builds to apply this flag consistently to them.

Note that this bug was confirmed by @garazdawi in an Erlang forum post: https://erlangforums.com/t/unify-builds-for-otp-erts-targets/1419/3

[CLAassistant]

All committers have signed the CLA.

[github-actions[bot]]

CT Test Results

       4 files     135 suites   51m 20s :stopwatch: 1 611 tests 1 560 :heavy_check_mark: 51 :zzz: 0 :x: 2 001 runs  1 932 :heavy_check_mark: 69 :zzz: 0 :x:

Results for commit 1bc6daff.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[garazdawi]

Hello! Thanks for the PR! Would you mind signing the CLA?

[d1jang]

Hello! Thanks for the PR! Would you mind signing the CLA?

Done!

[d1jang]

You need to also change erts/configure.ac to include flavor.mk.in as erts/configure is a generated file.

Thanks for the comment! I included the requested change in [erts/configure.ac].

[d1jang]

@garazdawi I made the requested change. Can I ask for a quick review? Thanks!

[RaimoNiskanen]

@d1jang: I am afraid @garazdawi is on vacation until mid August. Maybe someone else in the team can find the time to have a look, but do not hold your breath...

[garazdawi]

Hello again! The changes in this PR break the building of a non-jit emulator. To reproduce run:

./otp_build setup -a
make FLAVOR=emu

[garazdawi]

I've pushed changes to your branch to fix the issues and add CI in order to check that the different types and flavors works.