otp
otp copied to clipboard
ssl: Store ClientCert in Stateless SessionTicket
During session resumption with stateless tickets a previously verified client certificate will not be available in the resumed session. Storing the certificate in the session ticket allows us to retrieve it during session resumption handshake.
This PR is related to #5870 but only covers the case of storing the client certificate.
CT Test Results
Tests are running... https://github.com/erlang/otp/actions/runs/2264360086
Results for commit 00378bb01cf4dbc874949a7df4b932e667ca6803
To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.
See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.
Artifacts
- No CT logs found
- No HTML docs found
- No Windows Installer found
// Erlang/OTP Github Action Bot
tls_server_session_ticket_SUITE seems to be skipped, this is now dependent on #5951 (along with work on the tests)
please resolve conflicts and push an update to enable test execution on our side
Hi @u3s, I have resolved the conflicts
We will get to this we just want to resolve the other PR regarding stateless tickets first.
Perfectly reasonable, I appreciate the update
Hi @IngelaAndin and @u3s, have you had any time to look at this?
I just quickly rebased to clear up the conflict
we will have a discussion and let you know. should happen this or next week.
Thanks for the review, I will try and find the time to implement the requested changes as soon as possible.
This PR can be closed in favor of #6362