otp icon indicating copy to clipboard operation
otp copied to clipboard

ssl: Store ClientCert in Stateless SessionTicket

Open sindrip opened this issue 3 years ago • 7 comments

During session resumption with stateless tickets a previously verified client certificate will not be available in the resumed session. Storing the certificate in the session ticket allows us to retrieve it during session resumption handshake.

This PR is related to #5870 but only covers the case of storing the client certificate.

sindrip avatar May 03 '22 14:05 sindrip

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 03 '22 14:05 CLAassistant

CT Test Results

Tests are running... https://github.com/erlang/otp/actions/runs/2264360086

Results for commit 00378bb01cf4dbc874949a7df4b932e667ca6803

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

  • No CT logs found
  • No HTML docs found
  • No Windows Installer found

// Erlang/OTP Github Action Bot

github-actions[bot] avatar May 03 '22 14:05 github-actions[bot]

tls_server_session_ticket_SUITE seems to be skipped, this is now dependent on #5951 (along with work on the tests)

sindrip avatar May 04 '22 08:05 sindrip

please resolve conflicts and push an update to enable test execution on our side

u3s avatar May 17 '22 08:05 u3s

Hi @u3s, I have resolved the conflicts

sindrip avatar May 18 '22 17:05 sindrip

We will get to this we just want to resolve the other PR regarding stateless tickets first.

IngelaAndin avatar Jun 18 '22 18:06 IngelaAndin

Perfectly reasonable, I appreciate the update

sindrip avatar Jun 18 '22 21:06 sindrip

Hi @IngelaAndin and @u3s, have you had any time to look at this?

I just quickly rebased to clear up the conflict

sindrip avatar Sep 05 '22 10:09 sindrip

we will have a discussion and let you know. should happen this or next week.

u3s avatar Sep 21 '22 12:09 u3s

Thanks for the review, I will try and find the time to implement the requested changes as soon as possible.

sindrip avatar Oct 03 '22 08:10 sindrip

This PR can be closed in favor of #6362

sindrip avatar Oct 12 '22 12:10 sindrip