otp icon indicating copy to clipboard operation
otp copied to clipboard

wx: Detect OpenGL for cross compilation

Open joaohf opened this issue 3 years ago • 2 comments

Hello,

This PR intend to fix cross compilation issues for wx. And uses the same strategy following https://github.com/erlang/otp/pull/5728.

Without this patch I got:

builder@f985825fa055:/build/tmp/work/cortexa57-poky-linux/erlang/25.0-rc1-r0/git$ find -name config.log
./erts/config.log
./lib/crypto/config.log
./lib/common_test/config.log
./lib/wx/config.log
./lib/snmp/config.log
./lib/megaco/config.log
./lib/erl_interface/config.log
./make/config.log
builder@f985825fa055:/build/tmp/work/cortexa57-poky-linux/erlang/25.0-rc1-r0/git$ grep  'unsafe for cross-compilation' ./lib/wx/config.log
cc1: warning: include location "/usr/local/include" is unsafe for cross-compilation [-Wpoison-system-directories]

The general OpenGL detection is right, the issue is when the configure tries to find it in the alternative folders like /usr/X11R6 and usr/local/.

joaohf avatar Mar 06 '22 18:03 joaohf

CT Test Results

  1 files  11 suites   1m 43s :stopwatch: 80 tests 76 :heavy_check_mark: 4 :zzz: 0 :x: 84 runs  80 :heavy_check_mark: 4 :zzz: 0 :x:

Results for commit 547d87a3.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Mar 06 '22 18:03 github-actions[bot]

Same as #5770

IngelaAndin avatar Apr 25 '22 08:04 IngelaAndin