otp icon indicating copy to clipboard operation
otp copied to clipboard

fix #10366 reading out os:version() for windows - manifest.xml

Open cwmichi opened this issue 2 months ago • 4 comments

fixing issue #10366

cwmichi avatar Nov 13 '25 16:11 cwmichi

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kvakvs
:x: cwmichi
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 13 '25 16:11 CLAassistant

CT Test Results

Tests are running... https://github.com/erlang/otp/actions/runs/19338259761

Results for commit c0c2579858fbfaf1f8c395aee7c0218f2f3d7ca8

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

  • No CT logs found
  • No HTML docs found
  • No Windows Installer found

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Nov 13 '25 16:11 github-actions[bot]

A nitpick to the comment {8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a} covers all of the following: Windows 10, Windows 11, Windows Server 2016, Windows Server 2019 and Windows Server 2022 I did test this and it works, and i will proceed with editing the comment and merging

kvakvs avatar Dec 03 '25 16:12 kvakvs

Hello @cwmichi I have added a tiny comment update to your branch. Please squash the commits yourself, and rebase on latest OTP maint, and set the PR destination to maint OR use the branch i squashed and rebased in my clone of OTP: [email protected]:kvakvs/otp branch cwmichi/fix_windows_os_version

if you don't have time, also please let me know, i will proceed with making a copy of this PR with your commit and merging it.

kvakvs avatar Dec 15 '25 03:12 kvakvs

Hello @cwmichi I have added a tiny comment update to your branch. Please squash the commits yourself, and rebase on latest OTP maint, and set the PR destination to maint OR use the branch i squashed and rebased in my clone of OTP: [email protected]:kvakvs/otp branch cwmichi/fix_windows_os_version

if you don't have time, also please let me know, i will proceed with making a copy of this PR with your commit and merging it.

Hello @kvakvs it would be great if you can make a copy of this PR. Currently Windows Server 2025 is new, i don´t know if this is currently covered by the manifest.xml

cwmichi avatar Dec 17 '25 14:12 cwmichi