erlang_ls icon indicating copy to clipboard operation
erlang_ls copied to clipboard

Make edoc an optional dependency

Open filmor opened this issue 4 years ago • 3 comments

Some distributions (like the RabbitMQ Erlang distribution for RHEL/Fedora) may not include it, and as it's not installed via hex, start up will fail.

filmor avatar Apr 22 '22 14:04 filmor

Hi @filmor and thanks. Won't this causes some runtime errors if the application is not available? If we make the application optional, we should probably ensure those use cases degrade gracefully (eg not to show docs).

robertoaloi avatar Apr 28 '22 12:04 robertoaloi

It seemed to be doing exactly that (degrading gracefully), but I can check again.

filmor avatar Apr 28 '22 13:04 filmor

It does seem to degrade half-way gracefully, it doesn't take down all of erlang-ls, just the edoc calls are crashing. Definitely much better than the current state of things for me :)

filmor avatar May 06 '22 08:05 filmor