quixe icon indicating copy to clipboard operation
quixe copied to clipboard

Layout goes bad if the entire div is hidden

Open erkyrath opened this issue 4 years ago • 2 comments

The Borogove web-I7 service sometimes hides the story div. This results in a crash -- possibly because the status window gets measured at zero height.

Quixe init: TypeError: Cannot set property 'dirty' of undefined Cannot set property 'dirty' of undefined TypeError

The interpreter should at least not crash in this situation. (Maybe it should freeze all layout while the div is offscreen or zero-size?)

erkyrath avatar Oct 17 '20 04:10 erkyrath

Juhana commented (on Slack):

I managed to replicate, if you switch to another tab inside the editor while Quixe is loading it throws the error. Presumably it can't measure the window height correctly when it's hidden.

erkyrath avatar Oct 17 '20 04:10 erkyrath

I was not able to reproduce this, but I found a logic hole which could allow this error (overrunning the win.lines array) if win.gridheight was zero. Fixed.

erkyrath avatar Oct 23 '20 15:10 erkyrath