ponysay icon indicating copy to clipboard operation
ponysay copied to clipboard

Release for Python 3.8 compatibility

Open HaleTom opened this issue 4 years ago • 5 comments

% ponysay foo
/usr/bin/ponysay/backend.py:294: SyntaxWarning: "is not" with a literal. Did you mean "!="?
/usr/bin/ponysay/backend.py:294: SyntaxWarning: "is not" with a literal. Did you mean "!="?
 _______________
< foo           >
 ---------------
                  \
                   \
                    \
                     \  ▄▄
    ▄▄          ▄▄  ▄▄▄███▄
   ███▄▄▄▄▄▄▄  ████▄▄▄▄▄█▄█▄▄ ▄▄▄▄▄

HaleTom avatar Dec 11 '19 08:12 HaleTom

Oops, was resolved by 69c23e3ae1e1e9e9f1ee3a06a706d755a4b1de48.

My google-fu was weak.

HaleTom avatar Dec 11 '19 08:12 HaleTom

Would you consider another release given this makes things very ugly (and the last was 2017?)

HaleTom avatar Dec 11 '19 08:12 HaleTom

There is #254 and #263 that i want first to be adressed before doing a new release

Any patch for those is welcome

JotaRandom avatar Jan 10 '20 01:01 JotaRandom

To anyone with MacOS, stumbled upon this, you can temporarily fix your Homebrew package with following:

cd $(dirname $(readlink -f $(which ponysay)))
unzip ponysay -d source
vi +294 source/backend.py

replace is not with !=, like here

head -1 ponysay

note first line, in my case this line is

#!/usr/bin/env /usr/local/opt/[email protected]/bin/python3

python3 -m zipapp source -o ponysay_fixed -p "/usr/bin/env /usr/local/opt/[email protected]/bin/python3"

in -p argument set interpreter from previous step, without starting #! And finally, replace main ponysay link to fixed file:

cd $(dirname $(which ponysay))
ln -sf ../Cellar/ponysay/3.0.3_4/bin/ponysay_fixed ponysay

(make sure you point symlink correctly)

victordidenko avatar May 07 '20 14:05 victordidenko

As I see, issue was fixed in new Homebrew package:

ponysay 3.0.3_4 -> 3.0.3_5

Thank you!

victordidenko avatar Jun 03 '20 08:06 victordidenko