TradeSystem icon indicating copy to clipboard operation
TradeSystem copied to clipboard
Published 2 months ago • verified publisher icon erikzimmermann

Optimizing onPickup event

Open ItsSynchro opened this issue 3 years ago • 4 comments

Describe the bug I ran a spark report and had TradeSystem using 21.96% of the Server Thread due to the onPickup event. https://spark.lucko.me/ld9L7nw9kq

To Reproduce None

Expected behavior

Screenshots

Additional context Server version 1.18.1 Plugin Version 2.0.10

Discord contact: Synchro#7160

ItsSynchro avatar Feb 19 '22 03:02 ItsSynchro

Updated Spark as of 3/26/2022 https://spark.lucko.me/Y5ZszZLk9F

reconfirming that it causes a lag spike when the usage of TradeSystem increases

ItsSynchro avatar Mar 26 '22 22:03 ItsSynchro

Updated Spark as of 4/3/2022 https://spark.lucko.me/gxFmnigwJG

ItsSynchro avatar Apr 07 '22 20:04 ItsSynchro

Updated Spark as of 6/5/2022 https://spark.lucko.me/gY5q8vz3CE

EDIT: I found that using /tradesystem reload temporarily fixes the TPS drop

ItsSynchro avatar Jun 05 '22 19:06 ItsSynchro

Updated Spark as of 6/27/2022 https://spark.lucko.me/rQSCVCRO9s

ItsSynchro avatar Jun 27 '22 16:06 ItsSynchro

Fixed

erikzimmermann avatar Dec 16 '22 08:12 erikzimmermann