Erik Golinelli

Results 78 comments of Erik Golinelli

I understand your concerns, and I appreciate your feedback. Let me clarify my approach and workflow regarding the changes I've proposed. The reason why you didn't see those changes in...

> why manually create a type declaration, rather than use one generated by tsc? Currently, there are 400 errors in types, and the generated output doesn't match our expectations. While...

Sorry John, maybe I didn't provide enough context. The types from Definitely Typed are for version 4.0.4 and not for the current 8.0.0, and they are indeed very generic, sometimes...

@johnhooks After a bit of tweaking yesterday I managed to reduce the errors to 280, so I don't think the result is that far off. you should try the #89...

this shield should be added to the repository (it's useful as a link to the npmjs website) [![](https://img.shields.io/npm/v/gettext-parser.svg?label=npm%20version)](https://www.npmjs.com/package/gettext-parser)

bundlephobia reports a strange data about gettext-parser metadata. maybe something in the package json wasn't correct in the last version? https://bundlephobia.com/package/[email protected] a similar repo weights 100 times less! What is...

yep that the reason why i decided to breakdown the previous issue into multiple tasks, this way the pr will be much less loaded and consequently quicker to verify if...

Yes i can't hide that I would be very pleased but at the same time I am aware that this is a very heavily used repository and i will still...

That would be great! Your experience is certainly a great help 🚀 ATM I'm moving the pull requests to the development branch, so they can be merged without touching the...

> Consider this branch as a pre-publication quality control checkpoint. I've included you in this process so that you have the "last word" over it. My intention was to utilize...