Erik Ringsmuth

Results 62 comments of Erik Ringsmuth

I see it now! This looks like a bug in Vulcanize or Polymer. I think the `../bower_components/` at the beginning of your paths is messing up Vulcanize. The vulcanized documents...

It's been a while since I debugged this issue but I think it had to do with vulcanize handling relative paths in imports. ``` html ``` I think part of...

Checking a standard list of DOM properties could work. The downside to that would be if the user actually wanted to use a query parameter like `hidden=true`.

I agree with @nomego on this one. One of the biggest things for me is keeping the API simple. It's easy to explain a `params` field vs. explaining a new...

Would the `bindRouter` attribute help in your case https://erikringsmuth.github.io/app-router/#/databinding/#bindrouter-attribute? It'd be tricky making a global method since it currently relies on the instance of the router to tell if it...

Yep, you can combine it with an imported page. ``` html ``` I've left out named routes on purpose. I know a lot of routers have them but I see...

The other tricky part of a URL builder is when the path has wildcards like `/customer/*/order/:orderId`.

The `` only looks for `` elements that are direct children. https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L205-L211 It works this way in case there are multiple nested routers so that the outer router doesn't use...

Can you post a simple code example? Is it differnet than this? ``` html ``` When it finishes transitioning from `first-page` to `second-page` it would remove `first-page` from the DOM....

So what does your URL change look like? Do you go from `/second` to `/second` and it replaces the whole view?