Erik Ringsmuth
Erik Ringsmuth
Seeing the code changed my mind about the `` tag https://github.com/erikringsmuth/app-router/pull/97/files#diff-8f495b0b37d1611ef1e4046e099aa7e1R181. The `` isn't adding benefit here since it only "projects" the elements at render time and doesn't actually move...
`if (element.toString() === "[object ShadowRoot]") { ...` and `if (route.tagName === 'CONTENT') { ...` may work, but I really don't like how hacky it is. If a selector like `router.querySelectorAll(':host...
The biggest issue would be making it work with the `core-animated-pages` feature since it expects only 1 page selected at a time. Is this something that would work with multiple...
I haven't tried 0.8 yet but I think everything should still work unless they changed the `core-animated-pages` API. The router is plain JS. I'll have to try out 0.8 soon...
The Polymer APIs changed, but the router doesn't use Polymer. It's a plain JS custom element. To that extent, Polymer's changes shouldn't affect the router at all.
It uses Shadow DOM if `core-animated-pages` is enabled.
Thanks @mbleigh! I'll keep the issue open as a placeholder for updating the documentation and examples.
`core-animated-pages` is a big ugly bunch of code spread across the router. I don't see myself having the time and energy to cut this over to `neon-animated-pages` anytime soon. :+1:...
It looks like these 2 places contain all of the code: https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L63-L103 https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L378-L414 There's probably an alternative event to `core-animated-pages-transition-end` that needs to be listened to. https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L95 Go for it!...
I can't reproduce this. I can run vulcanize and convert an element like this. > elements/test-el.html ``` html test ``` to this > dist/test-el.html ``` html test Polymer('test-el'); ``` and...