Erik Ringsmuth

Results 62 comments of Erik Ringsmuth

Where do you get the auth-token to start? Is that checked in a `state-changed` event handler?

Is there an ajax call to populate the globals element? You could manually initialize the router after the globals element has been populated. https://erikringsmuth.github.io/app-router/#/api#init

Hey Rob, This sounds like an additional lifecycle event. I have the current ones documented at the bottom of the API page https://erikringsmuth.github.io/app-router/#/api. When I first created these I wasn't...

Here's a concept. I created a [route-events](https://github.com/erikringsmuth/app-router/commit/25a12e3fdbdc6f618f9d476ca09b7f99b40833ce) branch with this addition. You can pull it through Bower: ``` "app-router": "erikringsmuth/app-router#route-events" ``` This adds a new `activate-route-content-loaded` event that gets fired...

That name may be a little misleading. It's really a `core-animated-pages` pre-transition event. If you don't use `core-animated-pages` nothing happens between `activate-route-content-loaded` and `activate-route-end`. I should also probably write up...

I made a few changes to the lifecycle event documentation http://erikringsmuth.github.io/app-router/#/events. I threw a Polymer example in there too since that's how most people will probably use it.

I forked your contacts-app and created a version using app-router https://github.com/erikringsmuth/contacts-app/tree/app-router. You can check out the diff here https://github.com/erikringsmuth/contacts-app/compare/app-router. Biggest changes: - app.js is way smaller since all of the...

For something like this or the other `import-error` PR, would you ever be handling the event in production code or would this be more for debugging? If it's more for...

The concept seems right. That's the correct way to use `` to insert DOM. This is the code that loops over the ``s https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L188. You could try debugging here and...

Hm, the reason I went with `router.firstElementChild` and `route.nextSibling` is that `router.querySelectorAll('app-route')` will select all children ``s. The problem is that a page like `page-alarms` may also contain a router...