redux-form-material-ui icon indicating copy to clipboard operation
redux-form-material-ui copied to clipboard

Fix example in Readme

Open e-e-e opened this issue 6 years ago • 5 comments

I was scratching my head for about 30minutes as to why I could not get a label working correctly with checkbox. I was directly copying the example in the read me, but was getting erorrs in my app because FormControlLabel was undefined. I updated the import to statements and everything worked fine.

This closes #258.

e-e-e avatar Aug 01 '18 04:08 e-e-e

Codecov Report

Merging #271 into 5.0 will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              5.0     #271   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           8        8           
  Lines          24       24           
=======================================
  Hits           16       16           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9328e93...356f12b. Read the comment docs.

codecov[bot] avatar Aug 01 '18 04:08 codecov[bot]

Is this repo still being maintained? I was also stuck on this for a while and the README should be updated asap.

Robinnnnn avatar Sep 14 '18 15:09 Robinnnnn

change: import Radio from '@material-ui/core/RadioButton' to: import Radio from '@material-ui/core/Radio'

Also, maybe rename this repo to redux-form-material-ui@next to cover v1, v3, onwards?

brucegl avatar Sep 21 '18 09:09 brucegl

@erikras - any word on this - its a super small change which will help others new to your library massively.

e-e-e avatar Oct 04 '18 06:10 e-e-e

@erikras - any word on this - its a super small change which will help others new to your library massively.

A few more changes are needed, however, I just found https://youtu.be/WoSzy-4mviQ and I'm of the opinion that newbies should use react-final-form, especially as this project is active for now. If you need to use redux to use form data from outside the form, see https://github.com/final-form/react-final-form/blob/master/README.md#redux-example. @erikras does say "If you need to mutate your data via dispatching Redux actions, you should probably use Redux Form." I wonder if "probably" means that there may be a way to handle this case with react-final-form, or it could be resolved in the future.

brucegl avatar Oct 04 '18 15:10 brucegl