react-redux-promise-listener icon indicating copy to clipboard operation
react-redux-promise-listener copied to clipboard

Updated MakeAsyncFunction prop types to accept an ActionMatcher

Open lutangar opened this issue 7 years ago • 5 comments

Hi @erikras

A few changes on the prop types/flow def/doc to allow an ActionMatcher on resolve and reject props, without raising a warning (as seen in redux-promise-listener 1.1.0)

Keep up the good work!

Cheers.

lutangar avatar Nov 21 '18 15:11 lutangar

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
  Branches        4      4           
=====================================
  Hits           15     15
Impacted Files Coverage Δ
src/MakeAsyncFunction.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e7821f...9eb63ab. Read the comment docs.

codecov[bot] avatar Nov 21 '18 15:11 codecov[bot]

I suppose the version number should be bumped to 1.1.0 but I don't know what's your strategy on this. Let me know.

lutangar avatar Nov 21 '18 15:11 lutangar

Is there any news on this @erikras ?

JalilArfaoui avatar Jun 20 '19 15:06 JalilArfaoui

Any updates on when this will be merged?

AfrazHussain avatar Oct 23 '19 01:10 AfrazHussain

It's 2021 and I wonder what's the status on this :)

lutangar avatar Feb 04 '21 14:02 lutangar