generate_life_calendar icon indicating copy to clipboard operation
generate_life_calendar copied to clipboard
verified publisher icon eriknyquist

Add "--classic" flag, to print the original format without customization

Open cnoam opened this issue 2 years ago • 4 comments

Hi I wanted to have the option to just print the original format from WBW.

PS: fixed bug in acceptable date format, fixed readme

thanks Noam

cnoam avatar Jul 10 '23 12:07 cnoam

Thanks for the PR @cnoam, I like the change, just have some questions/requests

eriknyquist avatar Jul 11 '23 01:07 eriknyquist

  • I don't remember the workflow: when I will push a new commit, will it be part of this PR?
  • when is a good time to push? After you mark the comments as resolved, or before?

cnoam avatar Jul 11 '23 07:07 cnoam

Sorry, I guess I misunderstood your changes on first review-- I didn't realize it was just a blank calendar with no personal date information. Now that I understand that, I don't think this is a feature that I want.... if someone wants a blank PDF calendar, with no personal dates, it's probably just as easy for them to make their own in Word, than it is to figure out how to get a working pycairo install and figure out how to use this script.

In other words, the only useful thing about the generate_life_calendar.py script, is that it annotates the calendar with your personal dates. Since this option removes that feature, I don't think it's a useful one. It would be a similar amount of effort to just make your own PDF from scratch.

However, I might be wrong, so I'm gonna leave this open for a while , because I'm curious if anyone else also wants this feature.

eriknyquist avatar Jul 12 '23 02:07 eriknyquist

Ok, thanks.

בתאריך 12 ביולי 2023 5:26,‏ Erik Nyquist @.***> כתב:

Sorry, I guess I misunderstood your changes on first review-- I didn't realize it was just a blank calendar with no personal date information. Now that I understand that, I don't think this is a feature that I want.... if someone wants a blank PDF calendar, with no personal dates, it's probably just as easy for them to make their own in Word, than it is to figure out how to get a working pycairo install and figure out how to use this script.

In other words, the only useful thing about the generate_life_calendar.py script, is that it annotates the calendar with your personal dates. Since this option removes that feature, I don't think it's a useful one. It would be just as easy to make your own PDF from scratch.

— Reply to this email directly, view it on GitHubhttps://github.com/eriknyquist/generate_life_calendar/pull/11#issuecomment-1631754122, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZRDIM4F7UIBMD72CDNJPZDXPYDNNANCNFSM6AAAAAA2EPDMRA. You are receiving this because you were mentioned.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

cnoam avatar Jul 12 '23 05:07 cnoam