Erik Martin-Dorel
Erik Martin-Dorel
I tried rebuilding the branch on a fresh opam switch with `--deps-only --locked` on a macOS version 14.5. The bad news is that the compilation stalls with something like: ```...
FYI, the macOS log now says ``` [NOTE] You can retry with '--assume-depexts' to skip this check, or run 'opam option depext=false' to permanently disable handling of system packages. Running...
Hi @AltGr, good news! the branch is ready to merge from my point of view. Thanks again for this important PR! I just let you take a quick look at...
@AltGr Last question for you! → what is the status of these two dependencies? https://github.com/ocaml-sf/learn-ocaml/blob/50d5182db2c0cca9d41e2f11090a0228f418e0e3/learn-ocaml.opam#L86-L95 https://github.com/ocaml-sf/learn-ocaml/blob/50d5182db2c0cca9d41e2f11090a0228f418e0e3/learn-ocaml-client.opam#L59-L64
Thanks a lot @AltGr for your feedback and for the rebase! I propose to: * merge your PR as soon as the CI is green (thanks for handing the point...
Regarding the last failing CI job, it seems that the image `ocamlpro/ocaml:5.1` would need a rebuild or so. Other minor questions (follow-up of the upcoming merge of this PR): *...
Hi again, as the [ocamlpro/ocaml](https://hub.docker.com/r/ocamlpro/ocaml/tags) image was rebuilt this afternoon, I restarted the CI which was successful! So, merging now. Still, I'll wait for you green-light (notably, if you have...
Hi @monnier, thanks for your report and the patches! The code you touched was initially written by @cpitclaudel so I Cc him in case he'd like to comment as well....
This may be an interested feature! but meanwhile, this related (simpler) feature should be implemented first IMHO: * https://github.com/ocaml-sf/learn-ocaml/issues/177
Cc @CJs0800 here is a list of potentially useful documentation to address this issue: * some codebase entrypoint for this feature: this file: https://github.com/ocaml-sf/learn-ocaml/blob/87c7b7fe2698620213eeb5392a96f0f6c974c9af/src/app/learnocaml_index_main.ml#L258-L262 * https://developer.mozilla.org/en-US/docs/Web/API/Location/hash * functions of utils.js_utils:...